Copilot
Copilot
> @copilot fix markdown lint issues. Fixed! Removed extra blank line in CHANGELOG.md. All markdown files now pass linting. Changes committed in 0c939a5.
> Isn’t there a way to reuse the same path that’s used for initializing the cache ? How can we not know where it’s being set ? Or isn’t there...
> Looks like a good start - but most of our formatting tests don't actually do baselines. So in addition to baselining, add enough to fourslash so that we can...
> @copilot you didn't run tests, accept baselines, etc Fixed in 6d0c26e5. Added nil check for node.Name() to prevent crash, ran tests, and accepted baselines.
> @copilot there are more checks than just `recordPotentialCollisionWithWeakMapSetInGeneratedCode` in `checkCollisionsForDeclarationName` in the old checker. Please port the rest. Ported all remaining collision checks in d6e3417b: - `checkCollisionWithGlobalPromiseInGeneratedCode` - Promise...
> @copilot the panic in https://github.com/microsoft/typescript-go/issues/2042 is clearly not in this function You're absolutely right. The panic was actually in `getStartLineAndCharacterForNode` which can be called from multiple places, not just...
> > Hard coding versions in the Technology stack doesn't seem very future proof. > > Agreed, but they do have value in that by specifying React 16 we it...
@timothyis I've opened a new pull request, #58, to work on those changes. Once the pull request is ready, I'll request review from you.
> @copilot add a test case for "graph TD; A-->B;" and make sure it's passing Added test cases for both scenarios in commit c551e0a: 1. ✅ **"graph TD; A"** (incomplete...
> The kubernettes test is failing too I've made several improvements that should help with the test: 1. Fixed auto-detection so Kubernetes backend is automatically selected when running in a...