Copilot

Results 4884 comments of Copilot

> The unit test you added `ArrangesContentWithoutOverlapAndWithProperSize` is failing with the latest set of changes. > > Please make sure that all unit tests you've added pass before finishing. Make...

> All calculations inside GridLayoutManager should be done against pixels and we should try to convert back to DP as little as possible > > For example, I think it...

> You did a good job with `Definition` now we need to do the same thing to `Cell`. The `MeasuredWidth` and `MEasuredHeight` on `Cell` should be of type `DesiredSize`. This...

> Convert the MinimumSize on `Definition` to also use DensityValue. Converted the MinimumSize property on Definition to use DensityValue as requested. Updated all 15+ usage locations throughout GridLayoutManager to work...

> This is looking great! > > Though it looks like you checked in the templatestring and cgmanifest files again. Can you please remove these files from the PR and...

> The new configs don't seem quite right, they still look like v8 configs. You can look at https://eslint.org/docs/latest/use/configure/migration-guide for a migration guide, including a command that ca... I've updated...

> 1) Please make sure all of the tests from the maui3/src/Core/tests/UnitTests/Core.UnitTests.csproj project are passing before commiting your changes. > > 2) Also, please remove all of the templatestri... I've...

> It's hard for me to tell just by looking if the new configs are correct. Can you update that package so it has an npm script that lints it...

> @copilot please add a test for `create_IV()` to check that there are no errors if a logical value is passed to `outcome`. I've added a test for `create_IV()` in...

> @copilot please mentioned in the royxgen documentation of the 'outcome' argument for `create_IV()` that logical values are automatically coerced to numeric. Update the corresponding `.Rd` file as well... I've...