Copilot

Results 4907 comments of Copilot

> @copilot Because a top-level file could be duplicated within other archives (e.g. an MSI at the top level as well as within a VS.* nupkg), I think a better...

> > I understand the concern about duplicated files. To clarify the intended design: should the `DoNotUnpack` behavior be specified via `FileSignInfo` (per-file name) or `FileExtensionSignInfo` (per-ext... Implemented `DoNotUnpack` for...

> @copilot > > Please refactor `ExplicitCertificateKey` to a name that more clearly describes its actual use, such as `ExplicitSignInfoKey` (or something similar). The current name implies a direct relat......

> @copilot nice find. Are there other perf optimizations you can find for when users apply tokens to layers (the update.ts function)? Found and implemented several optimizations for the update.ts...

> @copilot plenty of CI test failed, what now. The CI failures were caused by test isolation issues - the tests were using a shared module-scoped fixture (`table1`), which meant...

> @copilot when several tests need to use different schemas, they need to create separate tables with new_test_table. But when several tests each need to insert different data with the...

> @copilot one of the things you forgot to test, and perhaps to address, is the issue of secondary index support - which I mentioned in the original issue you...

> @copilot your new test test_is_null_with_secondary_index failed, with: > ``` > # IS NULL on indexed column should require ALLOW FILTERING ... Fixed the issue - `add_is_null_restriction` wasn't adding restrictions...

> @copilot I was curious whether you tested "x IS NULL" and "x IS NOT NULL" when x is a key column (clustering key column or partition key column). The...

> > @scylladb/scylla-maint please review and trigger CI for this pull request **CI Build:** [jenkins.scylladb.com/job/scylla-master/job/scylla-ci/parambuild?PR_NUMBER=27558](https://jenkins.scylladb.com... I didn't request a review - that was an automated message from @scylladb-promoter. The PR...