Copilot

Results 4910 comments of Copilot

> @copilot OpenSSL still cannot be found during the cmake configure step for arm64 in the docker and ubuntu images. > > When validating the images build successfully, use a...

> @copilot 继续 Fixed in commit e2cde96. The issue was that the `ImageViewer` component's animation timer (setTimeout) wasn't being cleaned up when the component was unmounted. Added an `onBeforeUnmount` hook...

> @copilot whatever you add, make sure it actually has a basis in the original implementation, and not something made up Reverted the incorrect fix in commit aaefcb7a. The test...

> @copilot when is onlyConfiguredPackages set to false? Currently, `onlyConfiguredPackages` is never set to `false` - both call sites use the default value (`true`). The parameter was added based on...

> @copilot well, when we run the generate command, I expect it to apply to all the selected packages. In some cases that might be a single package -- when...

> @copilot OK, explain a little more how the `flub generate layerCompatGeneration` logic works The `flub generate layerCompatGeneration` command works as follows: **Package Selection:** - Extends `PackageCommand`, which supports package...

> @copilot I think we should change pnpm run -r layerGeneration:gen. that command should instead just call flub generate directly. if we were to do that, then how would we...

> @copilot Given the three opt-in options to suggested I think using the compat metadata as a signal is correct. I also think maybe we should add a --force flag...

> @copilot I think you can get rid of the onlyConfiguredPackages param for now.. It seems unneeded. Already done in commit 7bc2409. The `onlyConfiguredPackages` parameter was removed to simplify the...

> @copilot Merge the latest main branch, resolving any conflicts. Merged main branch in commit ce6cf23. Resolved conflict in test file where the command was renamed from `layerCompatGeneration.ts` to `compatLayerGeneration.ts`....