serverless-plugins icon indicating copy to clipboard operation
serverless-plugins copied to clipboard

Respect the serverless.yml's enabled flag

Open nicwise opened this issue 1 year ago • 2 comments

If you set enabled: false in your serverless.yml, this ignores it and keeps the local one running.

So, respect the enabled flag in serverless.yml

functions:
  kinesisHandler:
    handler: .build/main.kinesisEventHandler
    timeout: 120
    events:
      - stream:
          type: kinesis
          arn: ...
          maximumRetryAttempts: 0 # Quick retry
          parallelizationFactor: 10
          maximumRecordAgeInSeconds: 360 # 5 minutes
          enabled: false <----- now respected, was ignored before
          startingPosition: TRIM_HORIZON
          functionResponseType: ReportBatchItemFailures
  

nicwise avatar Feb 21 '24 02:02 nicwise

so.... merge? not merge?

nicwise avatar Mar 26 '24 00:03 nicwise

@silouone @AdrieanKhisbe it'd be awesome if this could be looked at 🙏 ❤️ - it's currently causing issues in our local environment as we hit the cap on the number of concurrent connections 😭

jonocairns avatar Mar 28 '24 02:03 jonocairns