DXHRDC-GFX icon indicating copy to clipboard operation
DXHRDC-GFX copied to clipboard

[Suggestion] Add a bunch of filters and Depth Buffer Access

Open donizettilorenzo opened this issue 4 years ago • 10 comments

First thing first: THANKS, this is simply great!

Second: to avoid the use of reshade on top of your plugin is it possible to add some basic filters (applied in this order)?

*Debanding Filter

from: https://github.com/crosire/reshade-shaders

*Quint Sharpening Filter

from: https://github.com/martymcmodding/qUINT/tree/master/Shaders

In this way DXHR DC could be visually perfect!

And maybe unlock the depth buffer access too ! (Or can you directly improve the SSAO?)

donizettilorenzo avatar Apr 27 '20 09:04 donizettilorenzo

And a simple question: can you describe in detail the "lighting fix" done in DC version of the lighting model and the differences among the 3 choices?

donizettilorenzo avatar Apr 27 '20 10:04 donizettilorenzo

Second: to avoid the use of reshade on top of your plugin is it possible to add some basic filters (applied in this order)?

And maybe unlock the depth buffer access too ! (Or can you directly improve the SSAO?)

I don't plan on features ReShade has, as I don't intend to make a replacement for it. I intend to stick strictly to DC's and HR's visuals.

And a simple question: can you describe in detail the "lighting fix" done in DC version of the lighting model and the differences among the 3 choices?

As mentioned in the blog post, I modified two kinds of differences in lighting shaders - the ones which were broken, and the ones which were working fine, but were dimmer. "DXHR DC fixed" applies changes only to those lighting shaders which were broken, while "DXHR" mode modifies every lighting shader I identified so far.

CookiePLMonster avatar Apr 27 '20 16:04 CookiePLMonster

Thanks! So putting ReShade on top is not problematic, right?

donizettilorenzo avatar Apr 27 '20 17:04 donizettilorenzo

Thanks! So putting ReShade on top is not problematic, right?

If it causes any issues, it's a bug. My wrapper is meant to work fine with whatever you have on top - RenderDoc, ReShade, SweetFX, etc.

CookiePLMonster avatar Apr 27 '20 17:04 CookiePLMonster

Perfect. I have only ONE concern. ReShade debanding is so "brutal" on medium (low is literally not removing the banding) that it removes the lighting banding but eats a big chunk of texture details in low contrast zones of the frame. There's a way to resolve the lighting banding directly in the lighting model, maybe using the approach of Skyrim SE? (64-Bit Render Target) Or some other tweak, cause really this game is SO visually ruined by the banding (I'll put here some screenshots to show how bad the situation always was no matter the version of the game).

donizettilorenzo avatar Apr 27 '20 19:04 donizettilorenzo

lossless PNG (Chiron building elevator door):

2

donizettilorenzo avatar Apr 27 '20 19:04 donizettilorenzo

This is what a 64 bit rendertarget can do (screenshot from the lastest beta of The Dark Mod now implementing 64 bit rendertarget to avoid the banding)

32 bit: https://postimg.cc/wyPFPp2Q 64 bit: https://postimg.cc/k6VvWHC6

So it would be awesome to add this tweak if possible.....

donizettilorenzo avatar May 04 '20 09:05 donizettilorenzo

I have a reasonably good monitor yet I literally can't see the difference between those, sorry.

CookiePLMonster avatar May 04 '20 09:05 CookiePLMonster

Just see the banding of the sky! (full image and look below) In DXHR the banding is more heavy and evident (I will provide a ascreenshot or just look at the sky in Montreal)

donizettilorenzo avatar May 04 '20 16:05 donizettilorenzo

Here's the banding (PNG image, so no compression artifacts)

https://ibb.co/JHG7fJR

donizettilorenzo avatar Nov 17 '20 00:11 donizettilorenzo