Jean-Sébastien Herbaux

Results 49 comments of Jean-Sébastien Herbaux

Closing for inactivity. Don't hesitate to ping me if you want to reopen it at some point.

> > Would it be possible to add unit tests to the convert-query-params? Dow e already have some? > > yeah, there are some not a lot, there are also...

Hi there, thanks **a lot** for opening this issue. I haven't answered before because I was in the process of reviewing the entire type system to list every change we...

Also it looks like you've some conflicts with the base branch

> This also does include a pretty good documentation, right? https://github.com/strapi/documentation/pull/1293 :slightly_smiling_face:

You've some conflicts to fix & we're good to go :slightly_smiling_face:

Hey, thanks for reporting this issue. Out of curiosity, could you share the interface definition of ApiAdAd (from types/generated/contentTypes.d.ts) ? Everything looks OK from what you've shared. If anyone of...

> I saw this was merged to main. Do we have an eta no when it will be fixed in a versioned release? Hey, we have releases coming out every...

LGTM regarding the tests, but we'll need to find a way to make the typescript unit tests work

Hello and thanks for your comment. Unfortunately, Alexandre is currently off and this is a draft PR that might be subject to changes. This won't get ready for review before...