convex

convex copied to clipboard

Assign one store per peer in `ConvexTest`

2

I noticed all peers are initialized with the same store. I would strongly suggest using 1 dedicated store per peer. Otherwise it masks potential `MissingDataException`s.

helins

Etch: novelty handler always called

3

I noticed the novelty handler is called no matter what, even when I know for a fact a ref is not novel. Unless I am missing something, it seems to...

helins

`Convex.acquire` uses `Stores.current()` as default

1

This is counter-intuitive because `Convex.create()` accepts an optional store. Hence, it is expected that the user given one would be used as default store. A side effect is that when...

helins

Should the registry allow registering inexistent accounts?

1

Current, the `cns-update` function in the registry allows registering any address, even if it does not exist. This does not really make sense so I would tend to add an...

helins

Rename `tailcall` to `bounce`?

2

Might be more intuitive for developers expecting a more regular tail call behaviour, since we don't require tail position.

mikera

Fatal error: destructuring non-symbol

2

I couldn't remember if `:as` in destructuring was implemented or not in CVX, so I tried it:  But it is not specific to `:as`. It fails...

helins

There is a potential significant performance improvement given incoming encodings: - Keep a array of `WeakReference` in `AStore` - Index this by some function of `ABlob.toLong()` - Use to lookup...

mikera

Improve error: literal notation of illegal symbolic values

2

No useful error message is provided when an illegal symbolic value is evaluated: ```clojure :42 ;; READER: Reader error: Parse error at Position{line=1, column=2} Source: Message: null '#42/24 ;; READER:...

helins

Complete `log` output

2

`log` capability is incomplete. We still need to: - Ensure log entries are captured sequentially within each transaction - Copy to overall log at end of transaction - Add log...

mikera

Improve error: incorrect scientific notation

2

A double specified in incorrect scientific notation results in an empty message: ```clojure 12e 12e12.78 ;; READER: Reader error: Parse error at Position{line=1, column=6} Source: Message: null ```

helins