convex icon indicating copy to clipboard operation
convex copied to clipboard

`merge` does not support blob-maps

Open helins opened this issue 4 years ago • 4 comments

Complains that a blob-map cannot be cast to a hash-map:

(merge (blob-map) (blob-map))

helins avatar May 09 '21 06:05 helins

Not trivial to implement efficiently, as it requires special support from the data structures. Can of course do in a simple way with repeated assocs.

Currently we only support regular hash maps for merge, though BlobMap support might make sense in the future.

mikera avatar May 09 '21 06:05 mikera

I guess it should be somewhat polymorphic?

helins avatar May 31 '21 19:05 helins

Yes I think this support makes sense.

mikera avatar Jun 01 '21 01:06 mikera

Might be best to implement in terms of a repeated assoc so that the behavior is in, then optimize later.

helins avatar Nov 13 '22 14:11 helins