ConverJens

Results 59 comments of ConverJens

@kennethyang404 Thanks for the input! I have made some progress and beam args can now be both placeholder and string. Right now the issue is that the resolving fails which...

@kennethyang404 @jiyongjung0 I think I got it working now. Just some testing left.

@jiyongjung0 @kennethyang404 Now everything works as expected. String, placeholder and string + placeholder inputs works as expected which means one can now do: ``` pipeline_py.Pipeline( pipeline_name='test_pipeline', pipeline_root=pipeline_root_path, metadata_connection_config=sqlite_metadata_connection_config( metadata_path), components=[dummy_beam_component],...

@gbaned I'm have had no time for the last week's and won't until mid to end of August. Will check the comments and make adjustments then. This hasn't been forgotten...

@rcrowe-google Yep, I have messed up my gitconfig and commited using another email. Will try to sort it out.

@kennethyang404 Fixed all comments according to your comments. Build fails on pre-existing protolint issues.

@rcrowe-google Indeed we are! I think the proto errors were preexisting and not related to my changes though. Correct me if I'm wrong.

@kennethyang404 Could you give it another round of review? I believe that we are finished now :) cc @jiyongjung0 @rcrowe-google

@kennethyang404 No worries! Hope you had a great vacation and thanks for the comment. I have amended it and the build is now passing. Let me know if there is...