avalanche icon indicating copy to clipboard operation
avalanche copied to clipboard

Core50 benchmark with ICARL strategy

Open gab709 opened this issue 4 years ago • 6 comments

ICarl strategy returns an error with Core50 benchmark: scenario = CORe50(scenario="nc", run=9)

The error is: AttributeError: 'GenericCLScenario' object has no attribute 'n_classes_per_exp'

Other nc benchmarks belong to "NCScenario" class and this issue does not appear.

gab709 avatar Oct 15 '21 18:10 gab709

As a quick fix, you can easily compute n_classes_per_exp yourself by using exp.dataset.targets.

AntonioCarta avatar Oct 18 '21 07:10 AntonioCarta

Update: benchmarks created with the method create_multi_dataset_generic_benchmark have the same problem (no attribute n_classes_per_exp and classes_order). I did not investigate much, but seems that also benchmarks created with create_generic_benchmark_from_filelists (as CORe50) have the same problem.

Maybe is related to the generic benchmarks?

ggraffieti avatar Nov 12 '21 10:11 ggraffieti

@ggraffieti I think it's related to how the structure of the generic benchmarks is.

I'd like to take up this issue. You can assign it to me.

How might I approach it? @AntonioCarta @ggraffieti

ashok-arjun avatar Dec 03 '21 18:12 ashok-arjun

When i create a paths_benchmark, the function have the same problem.

AttributeError: 'GenericCLScenario' object has no attribute 'n_classes_per_exp'

lantao1234 avatar Jun 24 '22 14:06 lantao1234

Is still an open issue? I'm facing the same problem with ICarL implementation.

ema-marconato avatar Jul 12 '22 06:07 ema-marconato

I have the same problem with ego objects benchmark and icarl. Is it still not fixed?

Melika-Ayoughi avatar Sep 16 '22 11:09 Melika-Ayoughi