avalanche
avalanche copied to clipboard
[WIP] Fix W&B Artifacts Integration and minor errors
Fixing some errors with the current artifacts integration.
Pull Request Test Coverage Report for Build 1080820141
- 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
- 2 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.02%) to 82.114%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| avalanche/evaluation/metrics/checkpoint.py | 0 | 1 | 0.0% |
| <!-- | Total: | 0 | 1 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| avalanche/benchmarks/scenarios/generic_definitions.py | 2 | 85.37% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 1075424779: | -0.02% |
| Covered Lines: | 10357 |
| Relevant Lines: | 12613 |
💛 - Coveralls
It seems that the copy.deepcopy(list(strategy.model.parameters())) does work but returns the params as a list cloned from the source generator object in the evaluation/metrics/checkpoint.py which when used in logging/wandb_logger.py doesn't seem to pass through the if isinstance(value, Tensor): line since it demands a Tensor while the metric returns a List.
Oh no! It seems there are some PEP8 errors! 😕 Don't worry, you can fix them! 💪 Here's a report about the errors and where you can find them:
avalanche/logging/wandb_logger.py:122:81: E501 line too long (83 > 80 characters)
avalanche/logging/wandb_logger.py:145:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:146:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:149:37: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:169:1: E303 too many blank lines (3)
3 E128 continuation line under-indented for visual indent
1 E303 too many blank lines (3)
1 E501 line too long (83 > 80 characters)
Oh no! It seems there are some PEP8 errors! 😕 Don't worry, you can fix them! 💪 Here's a report about the errors and where you can find them:
avalanche/logging/wandb_logger.py:122:81: E501 line too long (83 > 80 characters)
avalanche/logging/wandb_logger.py:145:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:146:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:149:37: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:169:1: E303 too many blank lines (3)
3 E128 continuation line under-indented for visual indent
1 E303 too many blank lines (3)
1 E501 line too long (83 > 80 characters)
Oh no! It seems there are some PEP8 errors! 😕 Don't worry, you can fix them! 💪 Here's a report about the errors and where you can find them:
avalanche/logging/wandb_logger.py:122:81: E501 line too long (83 > 80 characters)
avalanche/logging/wandb_logger.py:145:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:146:49: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:149:37: E128 continuation line under-indented for visual indent
avalanche/logging/wandb_logger.py:169:1: E303 too many blank lines (3)
3 E128 continuation line under-indented for visual indent
1 E303 too many blank lines (3)
1 E501 line too long (83 > 80 characters)
@digantamisra98 any news on this?
@AndreaCossu I am no longer at W&B. But I am happy to finish this but won't be able to before December. Thanks!
Added in #1463