chproxy icon indicating copy to clipboard operation
chproxy copied to clipboard

Proxy strips query params

Open simPod opened this issue 5 years ago • 6 comments

I'm sending the request with params like max_query_size. I would like to forward it to my replica through proxy.

Currently the proxy seems to strip it. Is there a way to disable it?

simPod avatar Oct 01 '20 07:10 simPod

Hi @simPod! Proxy strips GET params for a reason. Pls see https://github.com/Vertamedia/chproxy/blob/master/scope.go#L292 and https://github.com/Vertamedia/chproxy#security.

hagen1778 avatar Oct 04 '20 20:10 hagen1778

@hagen1778 thank you for the link. But what if I want to allow other params? There seems to be a no way to override or disable the behaviour. I'd like the chproxy to proxy and leave the rest to ClickHouse instances.

simPod avatar Oct 05 '20 05:10 simPod

I understand the frustration. The list of params is static since it is used in the cache key. So in order to extend/control it on demand - the hash package should be updated accordingly. It might be not that easy to implement and I don't have time to work on this project anymore. So any help will be appreciated. On the other hand, you can just make a fork and update/disable the list of params manually for your case.

hagen1778 avatar Oct 05 '20 16:10 hagen1778

Thank you for the answer, that leads me to slightly off topic question: what is the future of the project? :D Do I understand that any further maintenance is not planned except for OSS contributions? Thanks!

simPod avatar Oct 05 '20 16:10 simPod

I'll try to review PRs, respond to questions or fix critical issues. It is unlikely for me to work on any additional features so far. However, I'm not the only maintainer - @valyala wdyt?

hagen1778 avatar Oct 05 '20 19:10 hagen1778

Thank you for the answer, that leads me to slightly off topic question: what is the future of the project? :D Do I understand that any further maintenance is not planned except for OSS contributions? Thanks!

Hello @simPod, Contentsquare decided to continue evolution of the project. Therefore, you might expect new feature to arrive 🙂 The first one is already there - #135 distributed cache

gontarzpawel avatar Feb 17 '22 09:02 gontarzpawel

Closing this as this is the same issue as #338, which proposes an config option to allow for unsafe overrides.

Blokje5 avatar Jun 02 '23 10:06 Blokje5