chproxy icon indicating copy to clipboard operation
chproxy copied to clipboard

[Feature] Change status code to concurrent query failed on cancelled requests

Open NatSau02 opened this issue 2 years ago • 2 comments

Is your feature request related to a problem? Please describe. When sending concurrent queries with a syntax error, the response "500, concurrent query failed" is returned, although the clickhouse responds to such errors with 400 (screenshot). The same behavior is observed for requests with 404

Describe the solution you'd like 500 is a service error that requires attention and correction, I think it would be more accurate to return the status of the clickhouse response so that there are no differences and the response is more informative

Additional context Add any other context or screenshots about the feature request here. image

NatSau02 avatar Mar 01 '24 15:03 NatSau02

PR https://github.com/ContentSquare/chproxy/pull/405

NatSau02 avatar Mar 01 '24 16:03 NatSau02

FYI all the maintainers are a bit busy for the moment, we will review your 2 PR and issues next week

mga-chka avatar Mar 07 '24 08:03 mga-chka

https://github.com/ContentSquare/chproxy/issues/406 this solution was recognized as the best

NatSau02 avatar Apr 07 '24 09:04 NatSau02