chproxy icon indicating copy to clipboard operation
chproxy copied to clipboard

Add chproxy as the prometheus metrics namespace or prefix

Open bzon opened this issue 4 years ago • 2 comments

It would be nice if the metrics will have a namespace chproxy which will prefix each metrics with chproxy_.

E.g. chproxy_request_success_total instead of just request_success_total

The problem is that the metric names are commonly used and there is a high chance that aggregating will conflict existing metrics from other jobs in prometheus.

bzon avatar Jan 22 '21 14:01 bzon

Hello @bzon, I agree with your proposal. Would you mind submitting a PR?

gontarzpawel avatar Jan 19 '22 17:01 gontarzpawel

the current PR https://github.com/ContentSquare/chproxy/pull/221 is linked to this topic

mga-chka avatar Sep 12 '22 07:09 mga-chka

I'm closing this issue since a namespace was added in https://github.com/ContentSquare/chproxy/pull/221

mga-chka avatar Nov 18 '22 13:11 mga-chka