locust_exporter icon indicating copy to clipboard operation
locust_exporter copied to clipboard

Feature request: endpoint to gracefully quit the container

Open AbdelrhmanHamouda opened this issue 2 years ago • 4 comments

EDIT, updated post from a vague request to a more defined one!

This is a feature request to add a /quitquitquit endpoint to the container to exit gracefully. This allows the container to be used as a part of a job/cronJob. This is identical to the /quitquitquit exposed by istio in v1.3

AbdelrhmanHamouda avatar Aug 12 '22 13:08 AbdelrhmanHamouda

Hello @pperzyna, is it possible to take a look at this request and share your thoughts?

Thanks in advance,

AbdelrhmanHamouda avatar Aug 16 '22 10:08 AbdelrhmanHamouda

@AbdelrhmanHamouda, I am happy to review a PR

pperzyna avatar Sep 13 '22 11:09 pperzyna

A quick PR to add that endpoint: https://github.com/ContainerSolutions/locust_exporter/pull/36

graipher avatar Sep 26 '22 11:09 graipher

Hello @pperzyna, it would be much appreciated if the proposed PR can be reviewed (and hopefully merged). For my use case, the proposed changes look like a very nice fit!

This project is used in my organisation and having this limitation is causing some workarounds to be in place.

It is not my intention to sound "pushy", however, the current workarounds are "ugly" and are not "cloud native" which is something i wish we can change soon. also, thanks @graipher for taking the time to put this PR in place :)

Thanks in advance!

AbdelrhmanHamouda avatar Oct 19 '22 11:10 AbdelrhmanHamouda

@graipher thank you!

pperzyna avatar Oct 30 '22 04:10 pperzyna