constructorio-client-javascript icon indicating copy to clipboard operation
constructorio-client-javascript copied to clipboard

Fix: Browse and Search types

Open xkr47 opened this issue 6 months ago • 3 comments

Hi,

For at least the Search and Browse apis, there were a LOT of usage of Partial<...> when in fact almost all fields seem to always be present. I checked the api responses and also checked the online api documentation and these are the changes I feel pretty confident with. I hope you can consider at least most of these changes. I look forward to any feedback as well.

Instead of using Partial I tried to make only select fields optional using the ?: syntax. Also I split some interfaces into separate more specific ones to be able to provide better typings in all scenarios.

xkr47 avatar Oct 17 '25 11:10 xkr47

Hey @xkr47 , thanks for your contribution! We will review and get these merged

esezen avatar Oct 23 '25 18:10 esezen

@xkr47 my apologies for the delay. We looked into this PR and it's looking good. Since these are breaking (in terms of TS) changes, we are going to hold off merging this PR until our next major release which will be after BF period. If you urgently need these changes, let me know and we can look for alternatives to support you

esezen avatar Nov 10 '25 18:11 esezen

Yeah makes sense. No worries, we are going to use my PR branch directly in our project until then so december-january timeline is fine with us.

xkr47 avatar Nov 12 '25 07:11 xkr47