Consolatis

> If you build without xwayland by specifying no xwayland does functionality of xwayland go down the drain for those that need it? Yes. > If you build WITH xwayland...

Are there other examples / established patterns out there to show indicators? I am aware of adding things after / before the title like - `tok` == `always top`, `omnipresent`,...

I wonder if we should default to "server" if no window rule matches. I'd assume the majority of users actually want the app-id based icon from the configured icon theme...

Using "server" as default would also have the added benefit that we wouldn't change existing behavior but only add another source of icons for applications that didn't have an icon...

Thanks a lot for your feedback, really appreciate it! Will incorporate.

Addressed most of the feedback, the points mentioned in the top post still remain. > This introduces a subtle change in behavior for scaled_icon_buffer_set_icon_name() (only used for menu icons right...

> I initially thought using function pointer like this PR is the best way to conditionally swap the 2 code paths for icon lookup, but now I think my approach...

Cherry-picked the commit, changed the default to be app-id based (`server`) and rebased on master to we can test with X11 icons as well.

Hm.. we are currently doing \*way\* more work than necessary. E.g. we reload / resize the icon on any changes (like app-id or title) even if the outcome will be...

> Is there a good test client for the XWayland case? I've just used my ancient VLC version which doesn't use wayland by default. But I assume most GTK stuff...