Consolatis

Results 854 comments of Consolatis

> EDIT 2: It seems that the LABWC_PID is only for internal use. But I do not understand how would the exit parameter (-e) work then? Usually you'd call `labwc...

I remember reading an anecdote about dmabuf feedback causing an overflow of the wayland connection buffer and thus wlroots killing the client. AFAIR there were talks about wlroots potentially sending...

Another thing I noticed with this PR is that there are still some occurrences of `server->workspace_current->tree->children` in `src/osd.c`. Those should likely be removed / replaced in lockstep with the other...

We will delay this PR until 0.7.1 is released (we target for March 1st).

I am slightly concerned that this may break some touchscreen enabled applications as they now get the touch events but also the synthesized mouse events. Maybe we could store the...

> I think I am already doing that by checking to see whether surface is NULL in the touch_down handler - if I understand the code correctly, that should be...

I'd suggest something like this: ```c struct touch_point { int32_t touch_id; uint32_t x_offset; uint32_t y_offset; struct wlr_surface *surface; struct wl_list link; /* seat.touch_points */ }; .. static void touch_down(struct wl_listener...

The cursor emulation part is looking good to me. We still do have some asymmetry here (we only relay the touch_down on `->surface` but always relay touch_up and touch_move touch...

> > The cursor emulation part is looking good to me. We still do have some asymmetry here (we only relay the touch_down on `->surface` but always relay touch_up and...

Might update this post later with more thoughts. For on-demand I think we should only ever give focus automatically during map to keep it the same as for usual xdg...