quorum-key-manager icon indicating copy to clipboard operation
quorum-key-manager copied to clipboard

Model dependencies between Makefile target better

Open dolanor opened this issue 4 years ago • 0 comments

Makefile dependencies

All Makefile targets are not self-sufficient and requires that some target have been called before. It is not really clear which one, and in what order. Reading the Makefile doesn't give more information about it. So you need to try by yourself with the lack of documentation.

docker dependencies

For the dependencies between containers running, we could improve docker-compose.yml usage. Otherwise, the dependencies would be hard to model with Makefile as it depends on file update timestamp to decide to run a target or not. Running a docker-compose sourcing multiple yaml files could create the whole container dependency graph better and wouldn't need a possibly out of date documentation.

docker-compose -f docker-compose.yml -f ./deps/docker-compose.yml up

Also, it could improve the docker network creation/deletion.

dolanor avatar Oct 01 '21 14:10 dolanor