gnark icon indicating copy to clipboard operation
gnark copied to clipboard

Ensure test circuits can be compiled in parallel

Open ivokub opened this issue 3 years ago • 2 comments

See discussion here

ivokub avatar Dec 09 '21 18:12 ivokub

That is; compiling the same circuit in parallel is an issue, but I think mostly for internal testing. In a normal workflow, I don't see why a circuit developer would want to compile the exact same instance of a circuit more than 1 time, and in parallel (?).

gbotrel avatar Dec 09 '21 19:12 gbotrel

That is; compiling the same circuit in parallel is an issue, but I think mostly for internal testing. In a normal workflow, I don't see why a circuit developer would want to compile the exact same instance of a circuit more than 1 time, and in parallel (?).

Makes sense, there shouldn't be a plausible reason to compile the same circuit in parallel outside of testing infrastructure. But I guess within testing it is reasonable to have a lock on the circuit (in the TestCircuit structure) as the circuits are used in different tests and possibly compiled in parallel.

I guess this makes this issue less relevant, but still nice-to-have in the future.

ivokub avatar Dec 09 '21 23:12 ivokub