gnark icon indicating copy to clipboard operation
gnark copied to clipboard
verified publisher icon Consensys

fix: eval contribution encoding

Open jtguibas opened this issue 1 year ago • 1 comments

Description

Fixes # (issue)

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How has this been tested?

  • [ ] Test A
  • [ ] Test B

How has this been benchmarked?

  • [ ] Benchmark A, on Macbook pro M1, 32GB RAM
  • [ ] Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I did not modify files generated from templates
  • [ ] golangci-lint does not output errors locally
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

jtguibas avatar Sep 24 '24 00:09 jtguibas

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 24 '24 00:09 CLAassistant

Thanks @jtguibas for the contribution. I have seen the PR before, but have delayed merging it due to https://github.com/Consensys/gnark/pull/1297 touching same parts of the implementation. I'll discuss with @Tabaie if we can merge your contribution without affecting the other PR. But I guess we would have to rebase the other one anyway, so shouldn't be an issue.

ivokub avatar Nov 22 '24 12:11 ivokub

Thanks @jtguibas for the contribution. I have seen the PR before, but have delayed merging it due to #1297 touching same parts of the implementation. I'll discuss with @Tabaie if we can merge your contribution without affecting the other PR. But I guess we would have to rebase the other one anyway, so shouldn't be an issue.

Closing the PR - we don't serialize the Phase2Evaluations anymore - it can be instantiated from Phase2 and converted into keys using Phase2.Seal.

ivokub avatar Mar 11 '25 15:03 ivokub