gnark-crypto icon indicating copy to clipboard operation
gnark-crypto copied to clipboard

Feat/clean polynomial

Open ThomasPiellard opened this issue 1 year ago • 1 comments

Description

iop.Polynomial:

  • removed blinding -> easier to deal with blinding manually with KZG(blinded(p)) = Kzg(p) + KZG(blinding_factor)
  • code no longer panics when polynomials are evaluated LAGRANGE or LAGRANGE_COSET basis

Type of change

  • [x] New feature (non-breaking change which adds functionality)

How has this been tested?

  • [x] Test TestEvaluation

Checklist:

  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I did not modify files generated from templates
  • [x] golangci-lint does not output errors locally
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

ThomasPiellard avatar Jan 09 '24 17:01 ThomasPiellard

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/fftTestBitReverse 0s

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/friTestFRI 0s

+ verifying wrong opening should fail: OK, passed 10 tests.

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/iop [github.com/consensys/gnark-crypto/ecc/bls12-377/fr/iop.test]

ecc/bls12-377/fr/iop/polynomial.go:371:27: invalid operation: cannot index d.CosetTable (value of type func() ([]fr.Element, error))

📦 github.com/consensys/gnark-crypto/ecc/bls12-377/fr/sisTestReference 0s

📦 github.com/consensys/gnark-crypto/ecc/bls12-378TestCrossMultiExpG1 0s

TestEncodeToG1 0s

TestEncoder 0s

TestG1AffineCofactorCleaning 0s

TestG1AffineConversions 0s

TestG1AffineEndomorphism 0s

TestG1AffineInvalidBitMask 0s

TestG1AffineIsOnCurve 0s

TestG1AffineOps 0s

TestG1AffineSerialization 0s

TestG1SqrtRatio 0s

TestG2AffineCofactorCleaning 0s

TestG2AffineConversions 0s

TestG2AffineEndomorphism 0s

TestG2AffineInvalidBitMask 0s

TestG2AffineIsOnCurve 0s

TestG2AffineOps 0s

TestG2AffineSerialization 0s

TestHashToG1 0s

TestIsCompressed 0s

TestMapToCurve1 0s

TestMapToG1 0s

github-actions[bot] avatar Jan 09 '24 17:01 github-actions[bot]