rimble-ui
rimble-ui copied to clipboard
ConsenSysMesh
Modal component
Refactor to use the React portals (done).
Some functionality that could be added which would be helpful.
- option to close modal when clicked outside modal
Look at other examples of modals that are used. Get list of features that would be helpful to add to modals.
There are a couple ways to make this better - we should weigh pros/cons and decide if we want to implement for 1.0.
Acceptance criteria:
- Should have option to close modal when clicked outside of modal
- Should be WIA-ARIA accessible
E: 2D
@MikeLockz
option to close modal when clicked outside modal
What's the plan for getting this feature integrated? Should I do a PR? And if I do, how soon will it get published? I just want to understand the release cycle of this project before I start any work.
Hey @adrianmcli - I'm sorry to leave you hanging for so long. We've been working on a proprietary design system and haven't been actively developing on Rimble. We do have a Portal component (not documented) that is already being used by the Modal component (also not documented). That being said if there is additional functionality that you want to add and submit a PR for we will review and merge it in.
@adrianmcli - here are a couple links to check out:
- https://github.com/ConsenSys/rimble-ui/blob/master/src/Portal/index.js and
- https://github.com/ConsenSys/rimble-ui/blob/master/src/Modal/index.js