rimble-ui icon indicating copy to clipboard operation
rimble-ui copied to clipboard

Decrease theme colors

Open MikeLockz opened this issue 5 years ago • 3 comments

Audit the theme colors and find ones that can be removed.

Also, consider adding variants for action colors that do not rely on opacity but instead change the hue via a color transform function like lighten (success-light).

Acceptance criteria:

  • theme should only have appropriate colors

E: 1/2D

MikeLockz avatar Nov 11 '19 19:11 MikeLockz

This should also get reflected in the Figma kit.

MikeLockz avatar Nov 11 '19 19:11 MikeLockz

@gesquinca - does it make sense to rename to abstract additional color names to something less tied to color and more tied to function? When I want to override the color of the button text, instead of using text I have to set white: "black" which feels weird. Should there be a new theme.colors.buttonText value?

MikeLockz avatar Nov 18 '19 17:11 MikeLockz

@MikeLockz yes it does. That's why we added these values to the theme recently.

https://github.com/ConsenSys/rimble-ui/blob/master/src/theme.js#L7-L8

This doesn't apply to button colors, but it applies to text color in the page as a whole.

gesquinca avatar Nov 26 '19 18:11 gesquinca