rimble-ui icon indicating copy to clipboard operation
rimble-ui copied to clipboard

Add Ul and Li components

Open MikeLockz opened this issue 5 years ago • 2 comments

Is your feature request related to a problem? Please describe. Add Ul and Li styled-components to rimble-ui library.

Describe the solution you'd like I should be able to import { Ul, LI } from "rimble-ui" and add props to style such as margin, padding, and list-style types.

Describe alternatives you've considered These two elements can be added as style-components for each app that uses rimble-ui, which creates duplicated boilerplate code that could be included in the library.

MikeLockz avatar Jun 04 '19 16:06 MikeLockz

Where would the duplicate code be created?

Why can't we use <Text as="ul" /> or <Text as="li" /> ?

Does rimble-ui need to support every html element or css property a developer might use?

How do we evaluate what goes in the library and what doesn't?

How are other component libraries approaching this? Can we find some examples?

gesquinca avatar Jun 05 '19 14:06 gesquinca

Duplicate code has been from need ul/li in multiple repos. It would be better to have this functionality in the library.

For now, I like the as="ul" approach. Would we want to add a listStyleType prop to Text or is that also too specific of a prop?

Great questions on what should or should not go in the library. I'm not sure where to draw the line either.

MikeLockz avatar Jun 06 '19 03:06 MikeLockz