rimble-ui
rimble-ui copied to clipboard
ConsenSysMesh
Button doesn't honor props
Describe the bug Button.Text does not honor the color or position props
To Reproduce https://codesandbox.io/embed/3238jv38zp
Expected behavior Should be able to change the color and position of a Button.Text component.
Rimble UI Version
- 0.8.0 (latest)
I'd be happy to look into this, #264 or #263 this week if you'd like
I'd be happy to look into this, #264 or #263 this week if you'd like
@sublimatedpotato - It would be awesome if you could take a look at #264 and #263. For this problem with the Button we think there is an issue with the latest 0.8.0 release. There was a major refactor for the Button component and we want to figure out what went wrong on our end.
@MikeLockz you got it. I'll take a look and submit any issue specific questions I might have directly onto those issues. Will aim for a Thursday PR.
@MikeLockz I made a PR #281 that resolves the problem you described to me inside of the Flash component. It's not what is described in this ticket as a bug, so not sure how to move forward from here. This is probably worth doing still, but it involves more work because of how I'm using css custom properties to color buttons. You can see in the docs for Button how to use custom colors, but again, it's not exactly what is described here.
