py-eip712-structs Fixes bug #16

py-eip712-structs can handle structs that contain other structs and structs that contain arrays of primitives, but it breaks on structs that contain arrays of other structs.

This pull request fixes this.

Dec 22 '22 19:12 josh-davis-vicinft

@josh-davis-vicinft Thank you for your contribution! This bug often causes people to fork and modify the library. Unfortunately I don't have the ability to disable the pipeline (the original author has left, and it still seems to be linked to an old Travis account) and won't for a while as I'm on leave myself.

So it might be a few weeks before we can merge this and set up a new publication pipeline. Sorry for the delay!

Dec 22 '22 19:12 shane-t

When will you merge it?

Mar 04 '23 01:03 lukaskiss222

still not merged ....?

Apr 08 '23 03:04 flipdazed

If you are still motivated, you could backport the fix to https://github.com/BoboTiG/py-eip712-structs-ng and I would be happy to cut a new release. If you do so, please add a test 🙏🏻

Jan 11 '24 23:01 BoboTiG

Thanks @josh-davis-vicinft I backported part of that PR to https://github.com/BoboTiG/py-eip712-structs-ng/commit/1c85ea21cf912de46f91a1d96f7a0382b48d1b19 in order to fix #16.

I'll cut a new release for that specific fix, and it someone can share a reproduction code for "...but it breaks on structs that contain arrays of other structs", I'll be happy to work on a second fix.

Jan 12 '24 09:01 BoboTiG