em-imap icon indicating copy to clipboard operation
em-imap copied to clipboard

Compatiblity Issue on "ResponesError" with Ruby 1.9.3

Open thinkinginmath opened this issue 11 years ago • 1 comments

I ran into this run time error,

net/imap.rb:3480:in initialize': undefined methoddata' for "Unexpected continuation response from server":String (NoMethodError) from em-imap-0.5/lib/em-imap/continuation_synchronisation.rb:66:in `new'

In Ruby 1.9, class ResponseError is changed. The constructor takes an response other than an arbitrary error string.

Is there a plan to make this library compatible with 1.9?

Also, what is the typical way of a ruby gem to support both 1.8.7 and 1.9?

thinkinginmath avatar Dec 18 '13 17:12 thinkinginmath

The easiest solution in our case is probably to make it work with the 1.9.3 version of Net::IMAP, and ignore 1.8. If you want to spend more time, then we could copy one version of Net::IMAP into em-imap under a different name; or just add runtime switches so that it handles both correctly.

I'm not a huge fan of the Net::IMAP parser, so maybe eventually it'll go away completely — it's pretty awesome for what it does though.

ConradIrwin avatar Dec 18 '13 17:12 ConradIrwin