ConjuringCoffee

Results 86 comments of ConjuringCoffee

Maybe I'm missing something, but does this not work...? `DATA(lv_test) = |{ 'Some text'(001) } more text|.`

This would only be relevant when the class is also `FINAL`, right? (Also, relevant issue from the past: #104 )

Related issue: #191

You might want to get in touch with @stockbal. He was working on a GitHub workflow last year: https://github.com/SAP/abap-cleaner/issues/118#issuecomment-1741860852

> this would of course make the comparison with previous revisions rather difficult to read You're right, I didn't consider older system releases: On newer releases you can use a...

> I think such a cleanup rule should anyway only work if you select the whole code document (to include both the definition and the implementation part of a class),...

It seems like the rule is much more situational than I initially thought. I think my main use case isn't even with global classes, but when writing unit tests: I...

> FOR TESTING methods are always public to my knowledge. See the [SAP documentation](https://help.sap.com/doc/saphelp_nw74/7.4.16/en-us/49/25686a29ac16b7e10000000a42189d/content.htm?no_cache=true): > Test methods should be private, or protected if the methods are inherited. Since test classes...

Related discussion: https://github.com/SAP/styleguides/issues/221

Aligning the comparison operator `=` for this example also looks a bit weird: ```abap IF sy-sysid = 'DEV' AND sy-mandt = '001'. WRITE 'OK'. ENDIF. ``` Maybe there should be...