ConjuringCoffee

> this sounds much like it SAP driven I agree. At the moment, Clean ABAP is more "community supported", with SAP still being the owner of the styleguide. I don't...

Can't this issue be closed? #251 from 2022 covered this matter sufficiently in my opinion.

> The main reason imho is the refactoring issue: it requires a lot more changes to cut&paste chained variables for refactoring than one-line-data-definitions. The most trouble you have when the...

> Due to the move to ADT I suggest changing your first proposition to mandatory due I think all coding changes / documentation should be take part in one place....

About two years have passed since I've opened this issue and I've come to some conclusions about the questions I had. ### If any short text is defined in ABAP...

Thanks for the contribution, but... 😉 > Please use English for issues, pull requests, and discussions. Due to the wide-spread presence of English as a second language, SAP uses English...

Hmm, `ZCL_AOC_SY_VARIABLE_ANALYZER` has a significant dependency to `ZCL_AOC_SCAN`. If the instantiation using code from `ZCL_AOC_UNIT_TEST` was encapsulated, then it would be possible to add unit tests directly for it. Currently,...

Hmm, this isn't yet behaving how I intended it to. `p_position` seems to be intended for the statement index, but it's also used for calculating the checksum? The checksum should...

I'm removing the checksum stuff from this pull request again. This seems to be a bigger topic and I shouldn't mix this here. I'm working on the unit tests now.

I have closed the pull request I made to fix this issue for now. [As Björn explained in his comment](https://github.com/SAP/styleguides/pull/299#issuecomment-1512691880), the `FINAL` keyword has more subtleties to it than I...