conduit icon indicating copy to clipboard operation
conduit copied to clipboard
verified publisher icon ConduitIO

feat: add fatal errors

Open raulb opened this issue 1 year ago • 1 comments

Description

Fixes https://github.com/ConduitIO/conduit/issues/1780

Quick checks

  • [x] I have followed the Code Guidelines.
  • [x] There is no other pull request for the same update/change.
  • [x] I have written unit tests.
  • [x] I have made sure that the PR is of reasonable size and can be easily reviewed.

raulb avatar Aug 28 '24 11:08 raulb

@maha-hajja I addressed all feedback I could apply, however there are still two open comments I responded to. Let me know what you think about those. Thanks for taking a look at this!

raulb avatar Aug 29 '24 13:08 raulb

@maha-hajja addressed feedback again! Please take another look 🙏🏻

raulb avatar Aug 30 '24 09:08 raulb