conduit icon indicating copy to clipboard operation
conduit copied to clipboard

Feature: Include what fields are being deprecated by the connector

Open raulb opened this issue 1 year ago • 5 comments

Feature description

Over time, connectors may deprecate configuration fields in favor of others. While these changes are documented in the readme (see conduit-connector-postgres and conduit-connector-kafka), we need a programmatic way to determine which fields are deprecated so clients can hide them from their configuration.

~Update: Consider a way to mark fields as sensitive if we consider it appropriate as well. This is for clients to determine in which situations is really important to obfuscate its values. If scope becomes to big, consider creating a separate issue for this.~ ⬅︎ This issue other was created for this purpose.

raulb avatar May 13 '24 16:05 raulb

This includes an addition in the connector protocol, to indicate if a specific parameter is deprecated (boolean field), a change in the SDK and ideally also support to populate the new field using paramgen. The deprecation can be detected if a field comment starts with Deprecated: (same as the idiomatic Go way of deprecating fields).

lovromazgon avatar May 13 '24 17:05 lovromazgon

I'm not sure if this belongs here or would be better handled in a separate issue.

But we have other config tagging needs outside of just what is deprecated. We also need a way to indicate if a field is sensitive or contains sensitive information so that we might automatically know when to obfuscate values on the platform.

Adding this consideration here in case there's some potential design pattern that can be derived from the requirements.

See conversation in Slack.

justmisosoup avatar May 14 '24 23:05 justmisosoup

@justmisosoup that could make sense.

raulb avatar May 17 '24 08:05 raulb

Update after today's Conduit weekly. I'll spike on this to get a sense of the scope we're dealing with. Hope to come back with better info around this time tomorrow about whether we'll be implementing this now or later.

raulb avatar May 20 '24 16:05 raulb

Created a discussion item here https://github.com/ConduitIO/conduit/discussions/1611.

Current estimate for implementation is (at least) two days. Moving back to To do again until we start implementation.

raulb avatar May 22 '24 10:05 raulb