xml-to-react icon indicating copy to clipboard operation
xml-to-react copied to clipboard

Run build after tests in travis to help prevent breaks

Open pgoldrbx opened this issue 7 years ago • 0 comments

Expected Behavior

Our tests run against src but not our build pipeline, which uses rollup. This leaves uncertainty when we update dependencies in our build chain.

Current Behavior

Travis only runs npm test currently, and tests run against our src (using babel)

Possible Solution

  • Adding the build script to travis would be a bare minimum to ensure that the build doesn't break.
  • Alternatively, we could run (or re-run) tests against the our build target(s). This would be more effort and possibly less friendly for local development.

Context

Maintenance becomes easier if we know dependency updates can be reliably accepted.

Your Environment

n/a

pgoldrbx avatar Feb 26 '18 17:02 pgoldrbx