gallery icon indicating copy to clipboard operation
gallery copied to clipboard

Images arent always displayed in the correct orientation when viewing an image

Open MoralCode opened this issue 6 years ago • 1 comments

When viewing images taken vertically (i.e. https://gallery.csh.rit.edu/view/file/36582), some browsers (i.e. new versions of firefox) correctly rotate the image based on its EXIF metadata, however, most browsers (i.e. chromium) still display it incorrectly.

in order to fix this for other browsers, there needs to be a fallback for when the image-orientation CSS property is not supported.

So far i've come up with:

  1. Since #45 seems to be rotating thumbnails server-side, maybe we could also rotate the images server-side before displaying them, however, it seems like the /api/files/get endpoint is just returning a link to s3, so this might be a pretty complicated way to do it.
  2. alternatively, maybe we could implement the rotation using CSS classes and have the view_file.html template look at the metadata and decide which to use

MoralCode avatar Oct 17 '19 15:10 MoralCode

IMO we should handle things server-side, specifically on upload, fixing both thumbnail and file orientation. Probably best to do it on the /upload POST

RamZallan avatar Oct 17 '19 19:10 RamZallan