Add CurrentDeposition test

[MRZirper]

add single particle Current Deposition test from EZ-paper to CI

[psychocoderHPC]

Looks like there are some temporary files in the commit e.g. #validate.sh#, ... Do we need the h5 files in the PR?

[PrometheusPi]

The CI is still not happy about this pull request. What is the status of this pull request @MRZirper @steindev ?

[MRZirper]

I do not have the knowledge to fix this. @steindev has to do it for me.

[steindev]

@MRZirper CI is complaining:

./share/picongpu/tests/CurrentDeposition/lib/python/test/CurrentDeposition/MainTest.py contains non-ASCII characters!
9:    path should have the form ��data_%T�� to provide access to all iterations.
47:    """reads the position values ��position_offset�� (grid_knot) and ��position��
87:        # Sp��hlen nicht vergessen!

And it seems you did not properly clean up the code...

[steindev]

@MRZirper A requirements.txt is required in share/picongpu/tests/CurrentDeposition/lib/python/test/CurrentDeposition. Similar to the one existing in KHI_grwothRate.

[steindev]

It looks like there is the old ZigZag current deposition method used in one of the cases in cmakeFlags that is not existent anymore.

/root/buildCI/params/CurrentDeposition/cmakePreset_8/include/picongpu/param/species.param:82:54: error: no template named 'ZigZagCIC' in namespace 'picongpu::currentSolver'
    using UsedParticleCurrentSolver = currentSolver::PARAM_CURRENTSOLVER<UsedParticleShape>;
                                      ~~~~~~~~~~~~~~~^
<command line>:20:29: note: expanded from here
#define PARAM_CURRENTSOLVER ZigZagCIC

[PrometheusPi]

@MRZirper and @steindev what is the status of this pull request? Who will implement the changes?

[PrometheusPi]

The code style is not yet conform to your code style.

[BrianMarre]

@MRZirper @PrometheusPi The code style check is failing since your branch is not up to date with the dev, causing the CI to revert PR #4643

You need to call git pull --rebase mainline dev(assuming usual remote naming) to bring your branch up to date with the dev and avoid the reversion.

[PrometheusPi]

@MRZirper and @steindev can this be reviewed?

[MRZirper]

@MRZirper and @steindev can this be reviewed?

I think so

[steindev]

@MRZirper Please don't forget to squash before the next push.

[steindev]

I am happy now. Please rebase and squash.

[psychocoderHPC]

You must update your example, there was a change in PMacc and one file is not available anymore. Please remove the include and run clang-format again.

/root/buildCI/params/CurrentDeposition/cmakePreset_5/include/picongpu/param/density.param:54:10: fatal error: 'pmacc/preprocessor/struct.hpp' file not found
#include <pmacc/preprocessor/struct.hpp>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[BrianMarre]

@steindev @MRZirper your particle.param is old, the interface changed, take a look here for the new interface

[BrianMarre]

By the way, the onePositionParam in your particle.param suffers from the same issue, you need to remove all instances of CONST_VECTOR.

[steindev]

@PrometheusPi please re-review. Or you old request of changes will be dismissed.

[steindev]

@ComputationalRadiationPhysics/picongpu-maintainers Last call for reviewing this additional test case!

[chillenzer]

From skimming through this, a number of comments from #4801 might apply here, too. If merging this is not a pressing matter, I'll have a more detailed look before the beginning of March which seems to be when we could expect any further work on this.

[steindev]

@MRZirper it looks like the PR will pass the CI. Please squash into one single commit (and rebase). Then we will merge.

[steindev]

Ohh, provided @chillenzer is happy with the changes you made... @chillenzer we will wait for your approval.

[MRZirper]

Why does the test fail here?

[steindev]

@MRZirper Last requirement: Please squash and rebase.