picongpu icon indicating copy to clipboard operation
picongpu copied to clipboard

Vector use signed T_dim template parameter

Open psychocoderHPC opened this issue 11 years ago • 3 comments

The class Vector uses a signed int as signature for T_dim. It should be uint32_t!

psychocoderHPC avatar May 06 '14 08:05 psychocoderHPC

@psychocoderHPC is this still relevant?

BrianMarre avatar Dec 08 '22 11:12 BrianMarre

I think so, template argument of T_dim is still an int, cf. (https://github.com/ComputationalRadiationPhysics/picongpu/blob/c6770395c9fe262bfad3a4a1e68af0995a2dce9f/include/pmacc/math/vector/Vector.hpp#L88).

steindev avatar Dec 18 '22 21:12 steindev

Yes, this issue is still there

psychocoderHPC avatar Dec 19 '22 15:12 psychocoderHPC