picongpu icon indicating copy to clipboard operation
picongpu copied to clipboard
verified publisher icon ComputationalRadiationPhysics

Replace TWTS by original well tested version

Open psychocoderHPC opened this issue 4 years ago • 2 comments

The current TWTS version includes some bugs, it is very hard to follow optimizations done in the past and identify the bug. @steindev and I decided to start again from @BeyondEspresso well-tested version and apply optimizations step by step.

register footprint optimizations:

  • FieldB: 95 -> 89 register

  • FieldE: 73 -> 60 register

  • [ ] do not merge, @steindev will do the validation

psychocoderHPC avatar Jul 30 '21 12:07 psychocoderHPC

Aaaarggh. Sorry @psychocoderHPC! I messed up your branch by trying to squash my fixes somewhere in between your commits. But this just lead to the fact, that my fixes where overwritten again by later commits. Unfortunately I just recognized this after pushing. Do not pull! Instead force push your original commits again. Sorry! :disappointed:

steindev avatar Sep 10 '21 20:09 steindev

Ok. I had another version lying around. So I could fix it myself. It is also rebased to current dev. Next I will apply the fixes. In a separate commit! :sweat_smile:

steindev avatar Sep 13 '21 14:09 steindev

I will close this PR since we can now use the incident field for TWTS.

psychocoderHPC avatar Mar 02 '23 16:03 psychocoderHPC