Wrong unitSI in radiation amplitude

[PrometheusPi]

The current implementation of the unitSI and unitDimension of the complex amplitude in the radiation plugin code is not correct. Due to the previous use of libSplash, fractional units were not possible and thus the unitSI and unitDimension of the Amplitude square was given (which is the value with physical meaning). However, with openPMD-api fractional unit Dimensions can be given and thus the correct values should be used. This fix will change the output file and thus should come after #3566 has been merged. The current implementation is self-consistent and supported also by the libraries.

Updating both the radiation plugin output and the tool chain is needed.

[psychocoderHPC]

@PrometheusPi Is this something that must be fixed before the release 0.6.0? If so please provide a PR until mid of this week.

[PrometheusPi]

@psychocoderHPC This is nothing that needs to be fixed for the upcoming release.

[sbastrakov]

@PrometheusPi is this fixed?

[PrometheusPi]

@sbastrakov not yet