picongpu icon indicating copy to clipboard operation
picongpu copied to clipboard

Laser definitions inconsistent

Open HighIander opened this issue 4 years ago • 3 comments

The plane wave laser has a parameter called "ramp_init", in the laser.param comments it is referenced as "laser_init", which it says is twice the time of the time the laser is initialized before/after the maximum. In the gaussian laser, the parameter is correctly named "laser_init", but its definition is different: without the "twice". Its just a little inconvenience, adding to the possible confusion of newbees :-) However, I would vow to unify the meaning and names of the variables.

HighIander avatar Jun 22 '20 14:06 HighIander

I agree - I was also confused today by this definition (despite being aware of it for years now) - The standard deviation is defined from the center of the pulse, but we multiply it by 0.5 before multiplying it with the init factor just as if the standard deviation would be a symmetrically defied as e.g. FWHM.

PrometheusPi avatar Jun 23 '20 14:06 PrometheusPi

@PrometheusPi is this issue still relevant in the new incidentField laser profiles?

BrianMarre avatar Mar 12 '24 13:03 BrianMarre

@BrianMarre Yes this is still an open issue: RAMP_INIT is used e.g. in PlaneWave and PULSE_INIT (changed by @steindev) is used in e.g. GaussianPulse

PrometheusPi avatar Jun 17 '24 12:06 PrometheusPi