picongpu
picongpu copied to clipboard
Confusing RAMP_INIT / PULSE_INIT
The RAMP_INIT
/PULSE_INIT
parameter inside laser.param
that controls how far from the plateau / peak the laser pulse is initialized still causes major confusion in my opinion.
@PrometheusPi said he is responsible for the initial implementation and has valiantly offered to make everything more clear. :crossed_swords: :shield: :+1:
I would say, in terms of simplification we should make sure that the following requirements are fulfilled by the new implementation:
- [ ] a single conversion with an obvious (to every user) conversion factor gives the initialization time in seconds
- [ ] the initialization time conversion factor stays reasonable for all microscopic or macroscopic setups
- [ ] the parameter is consistently named throughout all laser profiles
- [ ] all example
.param
files are updated with documentation changes as well - [ ] the documentation shows clearly how to do the conversion to time in SI units
- [ ] the sphinx documentation needs to be updated: docs/source/usage/workflows/laserPeakOnTarget.rst