cuda_memtest CMakeLists vs Makefile

Why do you have both a CMakeLists.txt and a Makefile? Which one is the preferred one?

Considering that the Makefile is being overriden by cmake, can it be removed to avoid ambiguity?

Dec 04 '19 15:12 grische

Hi and thanks for the report!

We maintain the CMakeLists.txt version. The old Makefile script is just lingering around from the long-term unmaintained repo that we forked from: https://sourceforge.net/p/cudagpumemtest

We should remove it accordingly, but it probably contains some hints in case someone actually wants to use the OpenCL version (instead of the CUDA tests that we focus on).

Dec 04 '19 18:12 ax3l

I personally also added a Spack package that builds from CMake, as recommended.

Dec 04 '19 18:12 ax3l

Considering that the Makefile is being overriden by cmake, can it be removed to avoid ambiguity?

Don't build CMake projects in-source, please. Create a temporary build directory and execute cmake <pathToSource> in it.

Dec 04 '19 18:12 ax3l

@ax3l Makes sense.

Could you add build instructions to the README? I assumed the cmake variant is the new one, but the readme clearly stated that the Makefile is the current version which was quite confusing.

Dec 04 '19 18:12 grische

Yes, good idea. We initially thought our changes might be accepted upstream again and tried to change as little as possible.

I think a decade later we can assume nothing will happen upstream anymore and so let's change more boldly along the repo lines ;)

Dec 04 '19 18:12 ax3l