farmer icon indicating copy to clipboard operation
farmer copied to clipboard

Published 20 hours ago • verified publisher icon CompositionalIT

Make zones configurable for Virtual Machines

Open collinkruger opened this issue 3 years ago • 4 comments

This PR closes https://github.com/CompositionalIT/farmer/issues/791

The changes in this PR are as follows:

  • Makes zones configurable on VMs

I have read the contributing guidelines and have completed the following:

  • [ ] Tested my code end-to-end against a live Azure subscription.
  • [ ] Updated the documentation in the docs folder for the affected changes.
  • [ ] Written unit tests against the modified code that I have made.
  • [ ] Updated the release notes with a new entry for this PR.
  • [ ] Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

collinkruger avatar Oct 13 '21 18:10 collinkruger

This currently doesn't deploy. The are some co-location things I need to work through. DFgkf64vDp

collinkruger avatar Oct 13 '21 18:10 collinkruger

Got Zones working with VM IP Addresses.

Here is some documentation that shows what forced the changes https://docs.microsoft.com/en-us/azure/virtual-network/ip-services/public-ip-addresses. Specifically look under the Standard and Basic sections for how Zones can be used.

I also updated the tests to check for both the default cases (Dynamic Allocation and Basic SKU), and when Zones are used (Static Allocation and Standard SKU)

collinkruger avatar Oct 13 '21 21:10 collinkruger

@collinkruger we've been adding zone support in a few resources, so I updated this PR to follow with what we've done in other resources. Thoughts on this approach?

ninjarobot avatar Apr 19 '22 02:04 ninjarobot

@ninjarobot, LGTM!

collinkruger avatar Apr 19 '22 14:04 collinkruger

Hi @collinkruger - can we look at getting the conflicts dealt with and the PR submitted on this one? Thanks

martinbryant avatar Aug 18 '23 11:08 martinbryant

Hi @martinbryant, unfortunately between work/school/family I won't have time to work on this until January 2024. Would you like for me to go ahead and close it until then?

collinkruger avatar Aug 18 '23 14:08 collinkruger

@collinkruger it's been a while, I hope you're doing well!

Availability zone support was added to VMs a while back and subsequently sets it on the public IP for a VM as well. I think you can close this, but I hope you'll find another opportunity to work on Farmer in the future.

ninjarobot avatar Aug 21 '23 17:08 ninjarobot

@collinkruger @ninjarobot thanks for the replies and will close now

martinbryant avatar Aug 25 '23 08:08 martinbryant