farmer icon indicating copy to clipboard operation
farmer copied to clipboard

Add option to set DAPR protocol for Container Apps

Open fatim opened this issue 3 months ago • 1 comments

This PR closes #1083

The changes in this PR are as follows:

  • Container Apps: Add support for setting Dapr protocol.

I have read the contributing guidelines and have completed the following:

  • [ ] Tested my code end-to-end against a live Azure subscription.
  • [x] Updated the documentation in the docs folder for the affected changes.
  • [x] Written unit tests against the modified code that I have made.
  • [x] Updated the release notes with a new entry for this PR.
  • [x] Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:

I don't have experience using container apps with Dapr in Azure. This change produces correct ARM config, I've used this doc as a reference - https://learn.microsoft.com/en-us/azure/container-apps/enable-dapr?tabs=arm1 Could somebody test this in Azure.

Below is a minimal example configuration that includes the new features, which can be used to deploy to Azure:

let httpContainerApp =
    containerApp {
        ...
        // Dapr config
        dapr_app_id "http"
        dapr_app_port 5000us

        // new parameter added by this PR
        dapr_app_protocol "grpc"
        ...
    }

fatim avatar Apr 01 '24 21:04 fatim

Thanks for this contribution!

This looks great in principle. @isaacabraham is going to have a look at it, apologies for the delay.

jwthomson avatar Apr 26 '24 15:04 jwthomson