Valkyrie icon indicating copy to clipboard operation
Valkyrie copied to clipboard

Published 20 hours ago • verified publisher icon ComposeGears

Export button disabled while exporting

Open nhCoder opened this issue 6 months ago • 7 comments

Export button disabled when exporting large number of icons like 4k+ at once in iconpack mode. When i select few icons it works. IDE: IntelliJ IDEA 2025.1.1.1 (Community Edition)

Image

nhCoder avatar May 27 '25 17:05 nhCoder

Hello, export button disabled if you have broken icon or have some duplicates

https://github.com/ComposeGears/Valkyrie/blob/c42a4331a3610ff12fa81100f9f86d5306b2b8cc/tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionViewModel.kt#L338

egorikftp avatar May 27 '25 17:05 egorikftp

At least show us some message regarding it. How would i know if there are broken or duplicates among 4k+ icons

nhCoder avatar May 27 '25 17:05 nhCoder

Agree, will update this logic. For now you can quick scroll the list of icons, broken will be red 🌚

egorikftp avatar May 27 '25 17:05 egorikftp

Just add suffix auto-numbering to duplicate icons or Atleasr give this option in setting.

nhCoder avatar May 27 '25 18:05 nhCoder

small prototype

https://github.com/user-attachments/assets/3837c700-2e80-4944-bf4e-cfca26a62ecc

egorikftp avatar May 28 '25 20:05 egorikftp

Please add functionality to append suffixes to duplicated items, such as icons with identical names. Duplicate icons should not be possible as I had selected them from a single directory, this appears to have been the source of the issue in my case. The observed icon names (Copy, Copy01, Copy02) are in my directory.

nhCoder avatar May 29 '25 01:05 nhCoder

Could you please send xml/svg file names that after detected as duplicates?

egorikftp avatar May 30 '25 10:05 egorikftp

Sorry for the delay, Here are the icons i m trying to make icon pack. You can check on this pack Thank you very much for the hard work.

stroke-rounded.zip

nhCoder avatar May 31 '25 13:05 nhCoder

thanks for icons! zip contains Re.svg and Re/.svg duplicates

I'm working on feature to auto resolve issues:

https://github.com/user-attachments/assets/5e5ccc74-9e51-4282-a512-6146c7dd58e8

egorikftp avatar May 31 '25 13:05 egorikftp

Appreciate that bro, waiting for the update

nhCoder avatar Jun 01 '25 11:06 nhCoder

Snapshot 0.15.0 released, you can install manually and check on your project 🙂

egorikftp avatar Jun 03 '25 06:06 egorikftp

Working like a charm but when auto resolves issue button is clicked the all icons in list are cleared

nhCoder avatar Jun 04 '25 17:06 nhCoder

@nhCoder Thanks, fixed!

egorikftp avatar Jun 04 '25 20:06 egorikftp

updated snapshot version: https://github.com/ComposeGears/Valkyrie/releases/tag/0.15.0-SNAPSHOT

egorikftp avatar Jun 05 '25 08:06 egorikftp

Image

Still a minor issue exist for same icons name but diffrent styles like for Stroke and Solid

nhCoder avatar Jun 14 '25 17:06 nhCoder

@nhCoder thanks for the case, its time to add tests 😄

egorikftp avatar Jun 16 '25 20:06 egorikftp

added in new snapshot

egorikftp avatar Jun 18 '25 08:06 egorikftp