content icon indicating copy to clipboard operation
content copied to clipboard

Added multi-arch support for content image

Open aditijadhav38 opened this issue 2 years ago • 4 comments

Signed-off-by: Aditi Jadhav [email protected]

Description:

  • Raising a PR for building multi-arch images for compliance-operator-content through Github action CI.

Created Github CI which can have github action and qemu static user on top of x86 arch and we are using binaries of Power and other archs which are enabling us to create Virtual env for those architectures by this way we are building multi-arch images.

Note: To make it work need to create below two secrets in github repo

  • QUAY_USER ---> quay username
  • QUAY_PWD ---> quay repo password

We have already raised issue for the same and we got approval to raise PR, below is the link for it: #79

aditijadhav38 avatar Aug 11 '22 12:08 aditijadhav38

Hi @aditijadhav38. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci[bot] avatar Aug 11 '22 12:08 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Aug 11 '22 12:08 github-actions[bot]

Code Climate has analyzed commit 8c15cc10 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

codeclimate[bot] avatar Aug 11 '22 13:08 codeclimate[bot]

@mrogers950 @lbragstad since you were reviewing https://github.com/ComplianceAsCode/compliance-operator/pull/80 do you think you could review this PR as well?

jhrozek avatar Aug 16 '22 07:08 jhrozek

@jhrozek @rhmdnd What do you think about this? Are there any further changes needed or are we good to go?

jan-cerny avatar Sep 27 '22 07:09 jan-cerny

The PR probably needs rebase for the right set of gating tests to be executed.

matejak avatar Sep 29 '22 16:09 matejak

@aditijadhav38 please rebase the PR on the top of the latest upstream master @jhrozek or @rhmdnd please check this PR

jan-cerny avatar Oct 21 '22 14:10 jan-cerny

As per discussion https://github.com/ComplianceAsCode/compliance-operator/issues/79#issuecomment-1290727572, multi-arch support is no longer required. Because the downstream RH catalog images are already having support for ppc64le, and they are working fine. Thus closing the PR.

aditijadhav38 avatar Nov 04 '22 12:11 aditijadhav38