content icon indicating copy to clipboard operation
content copied to clipboard

Fix sysctl OVAL 5.10 build

Open ggbecker opened this issue 3 years ago • 6 comments

Description:

  • Fix sysctl OVAL 5.10 build

ggbecker avatar Aug 08 '22 16:08 ggbecker

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Aug 08 '22 16:08 github-actions[bot]

This PR appears to only fix the build for RHEL 8; this helps but doesn't appear to fix the complete OVAL 5.10 build.

Mab879 avatar Aug 08 '22 20:08 Mab879

This PR appears to only fix the build for RHEL 8; this helps but doesn't appear to fix the complete OVAL 5.10 build.

All right, I'm going to check on other distributions as well. Thanks for the review.

ggbecker avatar Aug 09 '22 08:08 ggbecker

I have simplified the PR and compared with previous 5.10 criteria and it should match correctly what is expected to be present in OVAL5.10. The 5.10 sanity build now includes all rhel versions.

ggbecker avatar Aug 09 '22 09:08 ggbecker

Code Climate has analyzed commit 19d5056b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Aug 09 '22 10:08 qlty-cloud-legacy[bot]

@ggbecker: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-rhcos4-moderate 19d5056ba1ee1db95ab37603d575fc632ce1b57a link true /test e2e-aws-rhcos4-moderate
ci/prow/e2e-aws-rhcos4-high 19d5056ba1ee1db95ab37603d575fc632ce1b57a link true /test e2e-aws-rhcos4-high
ci/prow/e2e-aws-ocp4-cis-node 19d5056ba1ee1db95ab37603d575fc632ce1b57a link true /test e2e-aws-ocp4-cis-node
ci/prow/e2e-aws-ocp4-high-node 19d5056ba1ee1db95ab37603d575fc632ce1b57a link true /test e2e-aws-ocp4-high-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci[bot] avatar Aug 09 '22 12:08 openshift-ci[bot]