content icon indicating copy to clipboard operation
content copied to clipboard

Test missing references in a data stream

Open jan-cerny opened this issue 3 years ago • 7 comments

Description:

Update profile_tool.py to support also SCAP source data streams and change upstream test missing-references to consume data stream.

For more details, please read commit message of every commit.

Rationale:

This makes one test independent from XCCDF 1.1 which will help us to remove XCCDF 1.1 in future.

jan-cerny avatar Aug 04 '22 15:08 jan-cerny

Hello @jan-cerny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-08-23 07:12:36 UTC

pep8speaks avatar Aug 04 '22 15:08 pep8speaks

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Aug 04 '22 15:08 github-actions[bot]

I have resolved the conflict and rebased on the top of the latest supstream master branch.

jan-cerny avatar Aug 05 '22 15:08 jan-cerny

I have fixed Code Climate problem.

jan-cerny avatar Aug 09 '22 13:08 jan-cerny

Hello @jan-cerny , please rebase.

vojtapolasek avatar Aug 09 '22 15:08 vojtapolasek

I have rebased the PR on the top of the upstream master branch.

jan-cerny avatar Aug 10 '22 11:08 jan-cerny

@vojtapolasek I have rebased it again because they have changed the list of required tests in the CI. But, I would prefer to avoid a fourth rebase.

jan-cerny avatar Aug 23 '22 07:08 jan-cerny

Code Climate has analyzed commit 2a537647 and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 11

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.5% (-0.1% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Aug 23 '22 07:08 qlty-cloud-legacy[bot]

We were discussing the codeclimate report with @vojtapolasek and it seems that codeclimate doesn't fully recognize the visual indentation which is allowed by PEP8. So when fixing the codeclimate issues the pep8speaks would start to fail. We can avoid this by reformatting the code so that it would use hanging indent with indentation that are multiples of 4 and with no arguments after the opening parethesis. But, in general, we prefer to avoid checking in only whitespace changes in PRs if not necessary. I guess we need to improve the codeclimate configuration.

jan-cerny avatar Aug 23 '22 08:08 jan-cerny