content icon indicating copy to clipboard operation
content copied to clipboard

Introduce an uefi version of disable_interactive_boot

Open matejak opened this issue 3 years ago • 4 comments

Description:

This PR adds a new rule based on grub2_disable_interactive_boot

The new rule differs from the original one, as it uses the template which makes it uefi-aware, and the template also doesn't allow to narrow down what module arguments are OK and what aren't, so none are allowed.

Rationale:

  • Both legacy and uefi versions of bootloader rules are needed - UEFI is the future, and legacy BIOS is still used on many places.

  • Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2106857

matejak avatar Jul 27 '22 16:07 matejak

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 27 '22 16:07 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment) Open in Gitpod

Fedora Testing Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jul 27 '22 16:07 github-actions[bot]

Code Climate has analyzed commit 7d581b51 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 42.7% (0.0% change).

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Jul 29 '22 15:07 qlty-cloud-legacy[bot]

@matejak What is your plan?

jan-cerny avatar Aug 30 '22 07:08 jan-cerny

The BZ has been fixed by another means, and refactoring of grub2 rules should become a coordinated effort, so closing for the time being.

matejak avatar Sep 23 '22 14:09 matejak