content icon indicating copy to clipboard operation
content copied to clipboard

Adapt compare_ds.py to compare text elements (also includes a STIG Benchmark mode)

Open yuumasato opened this issue 2 years ago • 6 comments

Description:

  • Improve the script so that it can compare text elements in the Rule. Elements like title, description, fixtext and warning.
  • Includes a new option o compare STIG Benchmarks.

Rationale:

  • We need a tool to compare STIG Benchmark releases
  • We couldn't easily know what changed in a Rule, besides its remediation and checks.

yuumasato avatar Jul 22 '22 16:07 yuumasato

Hello @yuumasato! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-09-05 13:04:37 UTC

pep8speaks avatar Jul 22 '22 16:07 pep8speaks

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] avatar Jul 22 '22 16:07 openshift-ci[bot]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment Open in Gitpod

Oracle Linux 8 Environment Open in Gitpod

github-actions[bot] avatar Jul 22 '22 16:07 github-actions[bot]

The PR works great for me. It's probably a good idea to add an option to output files to a specific folder --output diff/ so it doesn't clutter the current directory.

ggbecker avatar Jul 25 '22 15:07 ggbecker

Is this still a draft PR?

ggbecker avatar Aug 09 '22 14:08 ggbecker

Code Climate has analyzed commit 2e70de1c and detected 70 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 19
Duplication 12
Style 36
Clarity 3

The test coverage on the diff in this pull request is 12.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 40.4% (-1.8% change).

View more on Code Climate.

codeclimate[bot] avatar Sep 05 '22 13:09 codeclimate[bot]

Thanks @ggbecker!

yuumasato avatar Sep 09 '22 07:09 yuumasato